[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wr
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper |
Date: |
Thu, 01 Aug 2013 18:02:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Luiz,
Am 01.08.2013 16:12, schrieb Jason J. Herne:
> From: "Jason J. Herne" <address@hidden>
>
> Add HMP cpu-add wrapper to allow cpu hot plugging via monitor.
>
> Signed-off-by: Jason J. Herne <address@hidden>
What are your thoughts on this?
Thanks,
Andreas
> ---
> hmp-commands.hx | 13 +++++++++++++
> hmp.c | 10 ++++++++++
> hmp.h | 1 +
> 3 files changed, 24 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 8c6b91a..cb8712b 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1587,6 +1587,19 @@ Executes a qemu-io command on the given block device.
> ETEXI
>
> {
> + .name = "cpu-add",
> + .args_type = "id:i",
> + .params = "id",
> + .help = "add cpu",
> + .mhandler.cmd = hmp_cpu_add,
> + },
> +
> +STEXI
> address@hidden cpu-add @var{id}
> +Add CPU with id @var{id}
> +ETEXI
> +
> + {
> .name = "info",
> .args_type = "item:s?",
> .params = "[subcommand]",
> diff --git a/hmp.c b/hmp.c
> index c45514b..9465bd4 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1475,6 +1475,16 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict
> *qdict)
> hmp_handle_error(mon, &errp);
> }
>
> +void hmp_cpu_add(Monitor *mon, const QDict *qdict)
> +{
> + int cpuid;
> + Error *err = NULL;
> +
> + cpuid = qdict_get_int(qdict, "id");
> + qmp_cpu_add(cpuid, &err);
> + hmp_handle_error(mon, &err);
> +}
> +
> void hmp_chardev_add(Monitor *mon, const QDict *qdict)
> {
> const char *args = qdict_get_str(qdict, "args");
> diff --git a/hmp.h b/hmp.h
> index 6c3bdcd..9effca5 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -87,5 +87,6 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict *qdict);
> void hmp_chardev_add(Monitor *mon, const QDict *qdict);
> void hmp_chardev_remove(Monitor *mon, const QDict *qdict);
> void hmp_qemu_io(Monitor *mon, const QDict *qdict);
> +void hmp_cpu_add(Monitor *mon, const QDict *qdict);
>
> #endif
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 3/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP Event integration, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper, Jason J. Herne, 2013/08/01
- Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper,
Andreas Färber <=
- [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 2/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP CPU Info, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements, Jason J. Herne, 2013/08/01
- [Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access, Jason J. Herne, 2013/08/01