[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return addr
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument |
Date: |
Tue, 27 Aug 2013 12:47:46 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Aug 27, 2013 at 12:26:00AM +0100, Peter Maydell wrote:
> On 26 August 2013 22:00, Richard Henderson <address@hidden> wrote:
> > Allow the code that tcg generates to be less obtuse, passing in
> > the return address directly instead of computing it in the helper.
>
> > +uint8_t helper_ret_ldb_mmu(CPUArchState *env, target_ulong addr,
> > + int mmu_idx, uintptr_t retaddr);
>
> > uint8_t helper_ldb_mmu(CPUArchState *env, target_ulong addr, int mmu_idx);
>
> I thought the reason we did it this way round was to avoid having
> so many arguments to helpers that we overflowed registers and
> into the stack on some calling conventions? Or does this not make
> much difference in practice?
>
That was indeed the idea, but I think it's a good idea to provide this
alternative for architectures supporting enough arguments in registers.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation, (continued)
- [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 4/7] tcg-i386: Tidy qemu_ld/st slow path, Richard Henderson, 2013/08/26
- [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Paolo Bonzini, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Aurelien Jarno, 2013/08/27
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Richard Henderson, 2013/08/27
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Peter Maydell, 2013/08/26
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument,
Aurelien Jarno <=
[Qemu-devel] [PULL 6/7] tcg: Tidy softmmu_template.h, Richard Henderson, 2013/08/26
[Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers, Richard Henderson, 2013/08/26
Re: [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization, Aurelien Jarno, 2013/08/27