[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_al
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() |
Date: |
Mon, 2 Sep 2013 17:39:55 +0200 |
User-agent: |
KMail/1.13.7 (Linux/3.2.0-4-686-pae; KDE/4.8.4; i686; ; ) |
Am Samstag, 31. August 2013, 19:22:39 schrieb Antony Pavlov:
> qemu_chr_fe_write() is capable of returning 0
> to indicate EAGAIN (and friends) and we don't
> handle this.
>
> Just change it to qemu_chr_fe_write_all() to fix.
>
> Reported-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Antony Pavlov <address@hidden>
> CC: Peter Crosthwaite <address@hidden>
> CC: Michael Walle <address@hidden>
> CC: Andreas Färber <address@hidden>
> ---
> hw/char/milkymist-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
> index 2e4b5c5..6e4bc20 100644
> --- a/hw/char/milkymist-uart.c
> +++ b/hw/char/milkymist-uart.c
> @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr,
> uint64_t value, switch (addr) {
> case R_RXTX:
> if (s->chr) {
> - qemu_chr_fe_write(s->chr, &ch, 1);
> + qemu_chr_fe_write_all(s->chr, &ch, 1);
> }
> s->regs[R_STAT] |= STAT_TX_EVT;
> break;
Acked-by: Michael Walle <address@hidden>
--
Michael
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write(),
Michael Walle <=