[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant callouts on raw devices |
Date: |
Fri, 13 Sep 2013 12:28:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/13/2013 04:25 AM, Peter Lieven wrote:
> if a raw device like an iscsi target or host device is used
> the current implementation makes a second call out to get
> the block status of bs->file. however, the raw driver already
> has called bdrv_get_block_status on bs->file.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block.c b/block.c
> index cf9db62..282943b 100644
> --- a/block.c
> +++ b/block.c
> @@ -3167,7 +3167,8 @@ static int64_t coroutine_fn
> bdrv_co_get_block_status(BlockDriverState *bs,
>
> if (bs->file &&
> (ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
> - (ret & BDRV_BLOCK_OFFSET_VALID)) {
> + (ret & BDRV_BLOCK_OFFSET_VALID) &&
> + strcmp(bs->drv->format_name, "raw")) {
> ret2 = bdrv_co_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
> *pnum, pnum);
> if (ret2 >= 0) {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 07/12] block: introduce bdrv_zeroize, (continued)
[Qemu-devel] [PATCH 06/12] iscsi: add .bdrv_get_info, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant callouts on raw devices, Peter Lieven, 2013/09/13
- Re: [Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant callouts on raw devices,
Eric Blake <=
[Qemu-devel] [PATCH 09/12] block/get_block_status: set *pnum = 0 on error, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 10/12] block/get_block_status: avoid segfault if there is no backing_hd, Peter Lieven, 2013/09/13
[Qemu-devel] [PATCH 12/12] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/09/13