|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command |
Date: | Tue, 24 Sep 2013 12:41:26 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 20/09/2013 16:01, Benoît Canet ha scritto: >> > + if (error_is_set(&local_err)) { >> > + error_propagate(errp, local_err); >> > + goto fail; > There is nothing to execute between error_propagate and fail: maybe we could > get rid of the goto. Or perhaps of the "else". Paolo >> > + } else { >> > + dinfo = blockdev_init(opts, IF_NONE); >> > + if (!dinfo) { >> > + error_setg(errp, "Could not open image"); >> > + goto fail; > Same. >> > + } >> > + }
[Prev in Thread] | Current Thread | [Next in Thread] |