Re: [Qemu-devel] [PATCH] qemu-char: Fix potential out of bounds accessto local arrayss

[Alex Bennée]

address@hidden writes:

> Latest gcc-4.8 supports a new option -fsanitize=address which activates
> an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation
> very early because two character arrays of size 8 are potentially written
> with 9 bytes.
>
> Commit 6ea314d91439741e95772dfbab98b4135e04bebb added the code.
>
> There is no obvious reason why width or height could need 8 characters,
> so reduce it to 7 characters which together with the terminating '\0'
> fit into the arrays.
>
> Cc: qemu-stable <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
<snip>

Reviewed-by: Alex Bennée <address@hidden>

-- 
Alex Bennée