[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset |
Date: |
Thu, 3 Oct 2013 16:54:04 +0300 |
On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote:
> PCI is handling resetting of its devices before the bus is reset,
> but this is only necessary because qdev is broken and usually does
> pre-order reset. Post-order is a much better definition. Drop
> the unnecessary flexibility that lets bus decide the reset order,
> convert to post-order, and make PCI use common code for reset.
Need to go carefully here. I remember a bunch of targets
were relying on reset in this order, though don't
have the detail right now.
What kind of testing did this patchset go through?
> Paolo Bonzini (4):
> pci: do not export pci_bus_reset
> pci: clean up resetting of IRQs
> qdev: allow both pre- and post-order vists in qdev walking functions
> qdev: switch reset to post-order
>
> hw/core/qdev.c | 47 ++++++++++++++++++++++++++++++++++-------------
> hw/pci/pci.c | 42 ++++++++++++++++++++----------------------
> hw/pci/pci_bridge.c | 2 +-
> include/hw/pci/pci.h | 1 -
> include/hw/qdev-core.h | 15 ++++++++++-----
> 5 files changed, 65 insertions(+), 42 deletions(-)
- [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Paolo Bonzini, 2013/10/03
- [Qemu-devel] [PATCH 1/4] pci: do not export pci_bus_reset, Paolo Bonzini, 2013/10/03
- [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs, Paolo Bonzini, 2013/10/03
- [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions, Paolo Bonzini, 2013/10/03
- [Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order, Paolo Bonzini, 2013/10/03
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Paolo Bonzini, 2013/10/03
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Michael S. Tsirkin, 2013/10/03
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Paolo Bonzini, 2013/10/03
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Michael S. Tsirkin, 2013/10/06
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Paolo Bonzini, 2013/10/06
- Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset, Paolo Bonzini, 2013/10/09