[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction
From: |
Will Newton |
Subject: |
Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction. |
Date: |
Thu, 3 Oct 2013 16:10:00 +0100 |
On 3 October 2013 15:34, Richard Henderson <address@hidden> wrote:
> On 10/03/2013 05:51 AM, Will Newton wrote:
>> + case 0: /* eq: Z */
>> + tcg_gen_movcond_i64(TCG_COND_EQ, ftmp3, cpu_ZF,
>> zero,
>> + ftmp1, ftmp2);
>> + break;
>
> Does this compile when configured with --enable-debug?
>
> It shouldn't, since movcond_i64 takes 5 _i64 variables,
> and your comparison variables are _i32.
No, thanks for picking that up. I was wondering if that was valid and
the code seemed to work. What's the best way to work around the
problem? Just extend everything up to 64bits?
--
Will Newton
Toolchain Working Group, Linaro