[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading |
Date: |
Thu, 03 Oct 2013 13:11:34 -0600 |
On Thu, 2013-10-03 at 20:46 +0200, Paolo Bonzini wrote:
> Il 03/10/2013 17:39, Alex Williamson ha scritto:
> > +static const MemoryRegionOps vfio_rom_ops = {
> > + .read = vfio_rom_read,
> > + .endianness = DEVICE_LITTLE_ENDIAN,
> > +};
> > +
>
> I think you need to define a write callback too (unless you're sure for
> some other reason that the area will never be loaded).
Ok, I was under the impression that the memory API would handle lack of
an accessor as not supporting that access. I can add a follow on patch
to make a dummy write function if my assumption isn't true. Thanks,
Alex
- [Qemu-devel] [PULL 0/6] VFIO updates for QEMU, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 1/6] vfio-pci: Add support for MSI affinity, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 2/6] vfio-pci: Test device reset capabilities, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 4/6] vfio-pci: Cleanup error_reports, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 6/6] vfio: Fix debug output for int128 values, Alex Williamson, 2013/10/03
- [Qemu-devel] [PULL 5/6] vfio-pci: Implement PCI hot reset, Alex Williamson, 2013/10/03
- Re: [Qemu-devel] [PULL 0/6] VFIO updates for QEMU, Anthony Liguori, 2013/10/09