|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert |
Date: | Thu, 10 Oct 2013 14:09:42 +0800 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 6.1; zh-CN; rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20 |
δΊ 2013/10/1 22:56, Eric Blake ει:
On 09/25/2013 06:16 PM, Wenchao Xia wrote:Also renamed snapshot_name to snapshot_id_or_name to tip better.s/to tip better/as a better hint of what it does/Signed-off-by: Wenchao Xia<address@hidden> --- qemu-img-cmds.hx | 2 +- qemu-img.c | 2 ++ qemu-img.texi | 7 +++++-- 3 files changed, 8 insertions(+), 3 deletions(-)Squash this into 5/7.
OK.
There may be compatiability issue for existing user, I think add -l and deprecate old -s,+ " 'snapshot_param' is param used for internal snapshot, format is\n" + " 'snapshot.id=[ID],snapshot.name=[NAME]'\n"Again, can you reuse the existing -s, instead of having to add -L, by
would be better.
making the command line parser smarter about whether it is seeing a single name vs. a string starting with 'snapshot.'?
[Prev in Thread] | Current Thread | [Next in Thread] |