[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents |
Date: |
Fri, 11 Oct 2013 14:04:53 +0800 |
An extra 'p++' after while loop when *p == '\n' will move p to unknown
data position, risking parsing junk data or memory access violation.
Cc: address@hidden
Signed-off-by: Fam Zheng <address@hidden>
---
block/vmdk.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 5d56e31..f2dda21 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -760,10 +760,13 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
}
next_line:
/* move to next line */
- while (*p && *p != '\n') {
+ while (*p) {
p++;
+ if (*p == '\n') {
+ p++;
+ break;
+ }
}
- p++;
}
return 0;
}
--
1.8.3.1
- [Qemu-devel] [PATCH] vmdk: Fix vmdk_parse_extents,
Fam Zheng <=