[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort |
Date: |
Mon, 14 Oct 2013 17:57:58 +0300 |
From: Marcel Apfelbaum <address@hidden>
A MemoryRegion with negative priority was created and
it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci
address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on write
Note: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be
implemented in another series
Signed-off-by: Marcel Apfelbaum <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/pci/pci_bus.h | 1 +
hw/pci/pci.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/include/hw/pci/pci_bus.h b/include/hw/pci/pci_bus.h
index 9df1788..2ad5edb 100644
--- a/include/hw/pci/pci_bus.h
+++ b/include/hw/pci/pci_bus.h
@@ -23,6 +23,7 @@ struct PCIBus {
PCIDevice *parent_dev;
MemoryRegion *address_space_mem;
MemoryRegion *address_space_io;
+ MemoryRegion master_abort_mem;
QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */
QLIST_ENTRY(PCIBus) sibling;/* this will be replaced by qdev later */
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 00554a0..25626b8 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)
return rootbus->qbus.name;
}
+static uint64_t master_abort_mem_read(void *opaque, hwaddr addr, unsigned size)
+{
+ return -1ULL;
+}
+
+static void master_abort_mem_write(void *opaque, hwaddr addr, uint64_t val,
+ unsigned size)
+{
+}
+
+static const MemoryRegionOps master_abort_mem_ops = {
+ .read = master_abort_mem_read,
+ .write = master_abort_mem_write,
+ .endianness = DEVICE_LITTLE_ENDIAN,
+};
+
+#define MASTER_ABORT_MEM_PRIORITY INT_MIN
+
static void pci_bus_init(PCIBus *bus, DeviceState *parent,
const char *name,
MemoryRegion *address_space_mem,
@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent,
bus->address_space_mem = address_space_mem;
bus->address_space_io = address_space_io;
+
+ memory_region_init_io(&bus->master_abort_mem, OBJECT(bus),
+ &master_abort_mem_ops, bus, "pci-master-abort",
+ memory_region_size(bus->address_space_mem));
+ memory_region_add_subregion_overlap(bus->address_space_mem,
+ 0, &bus->master_abort_mem,
+ MASTER_ABORT_MEM_PRIORITY);
+
/* host bridge */
QLIST_INIT(&bus->child);
--
MST
- [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 01/43] memory: Change MemoryRegion priorities from unsigned to signed, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 02/43] docs/memory: Explictly state that MemoryRegion priority is signed, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 04/43] hw/core: Add interface to allocate and free a single IRQ, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 05/43] hw/pci: add pci wrappers for allocating and asserting irqs, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 06/43] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 07/43] hw/vmxnet3: set interrupts using pci irq wrappers, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 08/43] hw/vfio: set interrupts using pci irq wrappers, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 10/43] hw/pcie: AER and hot-plug events must use device's interrupt, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 09/43] hw: set interrupts using pci irq wrappers, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 11/43] hw/pci: removed irq field from PCIDevice, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 12/43] cleanup object.h: include error.h directly, Michael S. Tsirkin, 2013/10/14