[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support |
Date: |
Fri, 18 Oct 2013 14:14:09 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 11, 2013 at 02:17:30PM -0400, Jeff Cody wrote:
> +/* Perform a log write, and then immediately flush the entire log */
> +int vhdx_log_write_and_flush(BlockDriverState *bs, BDRVVHDXState *s,
> + void *data, uint32_t length, uint64_t offset)
> +{
> + int ret = 0;
> + VHDXLogSequence logs = { .valid = true,
> + .count = 1,
> + .hdr = { 0 } };
> +
> +
> + bdrv_flush(bs);
It's useful to comment why a flush is necessary. In this case I think
you're flushing the disk write cache because you want newly allocated
block contents to be stable before writing the BAT update into the
log.
- [Qemu-devel] [PATCH v7 01/19] block: vhdx - minor comments and typo correction., (continued)
- [Qemu-devel] [PATCH v7 01/19] block: vhdx - minor comments and typo correction., Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 02/19] block: vhdx - add header update capability., Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 03/19] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header., Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 04/19] block: vhdx - log support struct and defines, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 05/19] block: vhdx - break endian translation functions out, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 07/19] block: vhdx code movement - move vhdx_close() above vhdx_open(), Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 06/19] block: vhdx - update log guid in header, and first write tracker, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 08/19] block: vhdx - log parsing, replay, and flush support, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 09/19] block: vhdx - add region overlap detection for image files, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support, Jeff Cody, 2013/10/11
- Re: [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v7 11/19] block: vhdx write support, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 12/19] block: vhdx - remove BAT file offset bit shifting, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 13/19] block: vhdx - move more endian translations to vhdx-endian.c, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 14/19] block: vhdx - break out code operations to functions, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 15/19] block: vhdx - fix comment typos in header, fix incorrect struct fields, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support, Jeff Cody, 2013/10/11