Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

[Alex Bennée]

address@hidden writes:

> On 18 October 2013 12:45,  <address@hidden> wrote:
>> From: Alex Bennée <address@hidden>
>>
>> Commit 9b8c69243 (since reverted) broke the ability to boot the kernel
>> as the value returned by unassigned_mem_read returned non-zero and left
>> the kernel looping forever waiting for it to change (see
>> integrator_led_set in the kernel code).
>>
>> Relying on a varying implementation detail is incorrect anyway so this
>> introduces a basic stub of a memory region for the debug/LED section
>> on the integrator board.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>>  hw/arm/Makefile.objs              |   3 +-
>>  hw/arm/integrator_debug.c         | 103 
>> ++++++++++++++++++++++++++++++++++++++
<snip>
>
> Oh, and this belongs in hw/misc/, since it's a standalone
> device model.
<snip>

Ahh I was pondering this. Surely as it's only associated with ARM (and
specifically integrator) it gets grouped with that?

I was following up on Andreas' comments and deciding between:

hw/misc/arm_integrator_debug.c with include/hw/misc/arm_integrator_debug.c

and what I went with.

The existing devices are a mix of inline ones in integratorcp.c and
integrator_pit which is in hw/timer/arm_timer.c.

Perhaps there should be an addendum to HACKING.txt or a doc/src_layout.txt?

-- 
Alex Bennée