[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] qemu-img: add special exit code if bdrv_check
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv2] qemu-img: add special exit code if bdrv_check is not supported |
Date: |
Thu, 24 Oct 2013 08:00:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/24/2013 07:53 AM, Peter Lieven wrote:
> currently it is not possible to distinguish by exitcode if there
> has been an error or if bdrv_check is not supported by the image
> format. Change the exitcode from 1 to 63 for the latter case.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> v1->v2: As Eric suggested changed the exitcode from 255 to 63.
>
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Should the man page document this exit status? Then again, it doesn't
document ANY exit status, so that could be a separate patch.
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 926f0a0..bf3fb4f 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -607,7 +607,7 @@ static int img_check(int argc, char **argv)
> if (output_format == OFORMAT_HUMAN) {
> error_report("This image format does not support checks");
> }
> - ret = 1;
> + ret = 63;
> goto fail;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature