Re: [Qemu-devel] [PATCH 03/19] General Support for VSX Helpers

[Richard Henderson]

On 10/24/2013 09:19 AM, Tom Musta wrote:
> 
> +#define GEN_VSX_HELPER_2(name, op1, op2, inval, type)                        
>  \
> +static void gen_##name(DisasContext * ctx)                                   
>  \
> +{                                                                            
>  \
> +    TCGv_i32 opc;                                                            
>  \
> +    if (unlikely(!ctx->vsx_enabled)) {                                       
>  \
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);                               
>  \
> +        return;                                                              
>  \
> +    }                                                                        
>  \
> +    /* NIP cannot be restored if the memory exception comes from an helper 
> */ \
> +    gen_update_nip(ctx, ctx->nip - 4);                                       
>  \
> +    opc = tcg_const_i32(ctx->opcode);                                        
>  \
> +    gen_helper_##name(cpu_env, opc);                                         
>  \
> +    tcg_temp_free_i32(opc);                                                  
>  \
> +}

I'm not a fan of delaying decode to the helpers...

You're mostly doing this to avoid passing 3-4 arguments
for the register numbers?


r~