[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/10] apic: Document why cannot_instantiate_with
From: |
armbru |
Subject: |
[Qemu-devel] [PATCH v2 04/10] apic: Document why cannot_instantiate_with_device_add_yet |
Date: |
Tue, 29 Oct 2013 17:08:11 +0100 |
From: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/intc/apic_common.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index ea420c7..aaef054 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass,
void *data)
dc->vmsd = &vmstate_apic_common;
dc->reset = apic_reset_common;
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
dc->props = apic_properties_common;
idc->init = apic_init_common;
+ /*
+ * Reason: APIC and CPU need to be wired up by
+ * x86_cpu_apic_create()
+ */
+ dc->cannot_instantiate_with_device_add_yet = true;
}
static const TypeInfo apic_common_type = {
--
1.8.1.4
- [Qemu-devel] [PATCH v2 00/10] Clean up and fix no_user, armbru, 2013/10/29
- [Qemu-devel] [PATCH v2 04/10] apic: Document why cannot_instantiate_with_device_add_yet,
armbru <=
- [Qemu-devel] [PATCH v2 03/10] cpu: Document why cannot_instantiate_with_device_add_yet, armbru, 2013/10/29
- [Qemu-devel] [PATCH v2 08/10] vt82c686: Clean up use of cannot_instantiate_with_device_add_yet, armbru, 2013/10/29
- [Qemu-devel] [PATCH v2 02/10] sysbus: Set cannot_instantiate_with_device_add_yet, armbru, 2013/10/29
- [Qemu-devel] [PATCH v2 06/10] ich9: Document why cannot_instantiate_with_device_add_yet, armbru, 2013/10/29
- [Qemu-devel] [PATCH v2 10/10] qdev: Do not let the user try to device_add when it cannot work, armbru, 2013/10/29