[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] move BlockdevRef definition before using it
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH] move BlockdevRef definition before using it |
Date: |
Wed, 30 Oct 2013 15:04:30 +0800 |
On Wed, Oct 30, 2013 at 2:52 PM, Amos Kong <address@hidden> wrote:
>
> From: Amos Kong <address@hidden>
>
> @BlockdevRef is used in @BlockdevOptionsGenericFormat and
> @BlockdevOptionsGenericCOWFormat.
NACK this patch.
@BlockdevOptions is used in @BlockdevRef, this change is meaningless.
> Signed-off-by: Amos Kong <address@hidden>
> ---
> qapi-schema.json | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 60f3fd1..8af8187 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4061,6 +4061,23 @@
> '*rw': 'bool' } }
>
> ##
> +# @BlockdevRef
> +#
> +# Reference to a block device.
> +#
> +# @definition: defines a new block device inline
> +# @reference: references the ID of an existing block device. An
> +# empty string means that no block device should be
> +# referenced.
> +#
> +# Since: 1.7
> +##
> +{ 'union': 'BlockdevRef',
> + 'discriminator': {},
> + 'data': { 'definition': 'BlockdevOptions',
> + 'reference': 'str' } }
> +
> +##
> # @BlockdevOptionsGenericFormat
> #
> # Driver specific block device options for image format that have no option
> @@ -4162,23 +4179,6 @@
> } }
>
> ##
> -# @BlockdevRef
> -#
> -# Reference to a block device.
> -#
> -# @definition: defines a new block device inline
> -# @reference: references the ID of an existing block device. An
> -# empty string means that no block device should be
> -# referenced.
> -#
> -# Since: 1.7
> -##
> -{ 'union': 'BlockdevRef',
> - 'discriminator': {},
> - 'data': { 'definition': 'BlockdevOptions',
> - 'reference': 'str' } }
> -
> -##
> # @blockdev-add:
> #
> # Creates a new block device.
> --
> 1.8.3.1
>
>