[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling |
Date: |
Wed, 30 Oct 2013 12:29:55 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Oct 27, 2013 at 03:41:34AM +0300, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <address@hidden>
>
> Currently we have few issues with P9_STATS_GEN:
>
> - We don't try to read st_gen anything except files or directories, but
> still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
> we present garbage as valid st_gen.
>
> - If we failed to get valid st_gen with ENOTTY, we ignore error, but
> still set P9_STATS_GEN bit in st_result_mask.
>
> - If we failed to get valid st_gen with any other errno, we fail
> getattr altogether. It's excessive: we block valid client use-cases,
> like chdir(2) to non-readable directory with execution bit set.
>
> The patch fixes these issues and cleanup code a bit.
>
> Signed-off-by: Kirill A. Shutemov <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|