[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !US
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !USE_UID16 |
Date: |
Sun, 02 Mar 2014 22:05:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 02.03.2014 20:36, schrieb Peter Maydell:
> The size of the UID/GID types depends on whether USE_UID16 is
> defined. Define a new put_user_id() which writes a uid/gid
> type to guest memory. This fixes getresuid and getresgid, which
> were always storing 16 bits even if the uid type was 32 bits.
>
> Reported-by: Michael Matz <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> The SuSE 1.6 tree has a fix for this bug (hence the
> reported-by:) but I preferred to fix it in a different
> way to avoid introducing more ifdefs.
Looks sensible to me,
Reviewed-by: Andreas Färber <address@hidden>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64, Peter Maydell, 2014/03/02
- [Qemu-devel] [PATCH 2/5] linux-user: AArch64: Implement SA_RESTORER for signal handlers, Peter Maydell, 2014/03/02
- [Qemu-devel] [PATCH 1/5] linux-user/signal.c: Fix AArch64 big-endian FP register restore, Peter Maydell, 2014/03/02
- [Qemu-devel] [PATCH 3/5] linux-user: Don't use UID16 on AArch64, Peter Maydell, 2014/03/02
- [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !USE_UID16, Peter Maydell, 2014/03/02
- Re: [Qemu-devel] [PATCH 4/5] linux-user: Fix getresuid, getresgid if !USE_UID16,
Andreas Färber <=
- [Qemu-devel] [PATCH 5/5] linux-user: Implement sendmmsg syscall, Peter Maydell, 2014/03/02
- Re: [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64, Richard Henderson, 2014/03/03
- Re: [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64, Riku Voipio, 2014/03/03