|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema |
Date: | Fri, 07 Mar 2014 09:13:17 +0800 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 6.1; zh-CN; rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20 |
δΊ 2014/3/7 3:58, Luiz Capitulino ει:
There is still something not solved perfectly, I'll update later,guess it can't catch upOn Thu, 06 Mar 2014 11:14:01 -0700 Eric Blake<address@hidden> wrote:On 01/06/2014 04:18 PM, Luiz Capitulino wrote:On Fri, 3 Jan 2014 07:10:29 +0800 Wenchao Xia<address@hidden> wrote:This series add support for tag/keyword 'event' in qapi-schema. A new file was created to store some helper functions in patch 2, patch 4 is the test case, patch 5 is a convert example. The implemention is done by generate API and a batch of parameters for each event define, it doesn't generate a struture and visit function in the background for every event, so it doesn't support nested structure in the define to avoid trouble. A callback layer is added to control the behavior. More detail can be found in patch 3's message and incode comments.The general approach seems good to me. Would be nice to get another reviewer though, maybe Eric and/or Michael.Just now looking at this thread. Is this still something that we want in 2.0, or at this point are we late enough to delay to 2.1?We could get this in if we get it posted and fully reviewed before hard freeze (which is on March 12). But I'd suggest postponing to 2.1.
with 2.0.
[Prev in Thread] | Current Thread | [Next in Thread] |