[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support |
Date: |
Fri, 07 Mar 2014 20:45:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 07.03.2014 20:23, schrieb Peter Maydell:
> On 5 March 2014 11:53, Gerd Hoffmann <address@hidden> wrote:
>> Hi,
>>
>> The input layer moves to a model modeled roughly after the linux
>> event layer. It also uses qapi to create all the data types needed.
>> First, because it is convinient to have all the support code generated,
>> and also to make it easier to integrate with qmp some day.
>>
>> Porting work has only be done on the UI side so far. Input device
>> emulation is still to be done.
>>
>> Pull v4 rebase, fix build failure.
>> Pull v3 combines all sdl2 changes into a single patch.
>> Pull v2 fixes minor issues and adds missing sign-offs.
>
> Applied; thanks for doing all those respins.
Still problems despite at v4 already:
CC hw/display/xenfb.o
/home/andreas/QEMU/qemu/hw/display/xenfb.c: In function ‘xen_init_display’:
/home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: passing
argument 2 of ‘graphic_console_init’ makes integer from pointer without
a cast [-Werror]
fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
^
In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0:
/home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: expected
‘uint32_t’ but argument is of type ‘const struct GraphicHwOps *’
QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head,
^
/home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: passing
argument 3 of ‘graphic_console_init’ from incompatible pointer type
[-Werror]
fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
^
In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0:
/home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: expected
‘const struct GraphicHwOps *’ but argument is of type ‘struct XenFB *’
QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head,
^
/home/andreas/QEMU/qemu/hw/display/xenfb.c:995:5: error: too few
arguments to function ‘graphic_console_init’
fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
^
In file included from /home/andreas/QEMU/qemu/hw/display/xenfb.c:39:0:
/home/andreas/QEMU/qemu/include/ui/console.h:282:14: note: declared here
QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head,
^
cc1: all warnings being treated as errors
make: *** [hw/display/xenfb.o] Fehler 1
Will try to cook up a patch later (inserting "0, " as seen elsewhere?)
if no one beats me to it.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PULL v4 17/38] input: mouse: add qemu_input_is_absolute(), (continued)
- [Qemu-devel] [PULL v4 17/38] input: mouse: add qemu_input_is_absolute(), Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 19/38] input: mouse: switch gtk ui to new core, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 27/38] input-legacy: remove kbd_put_keycode, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 30/38] input-legacy: remove kbd_mouse_event, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 31/38] input: move mouse mode notifier to new core, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 25/38] input: mouse: switch cocoa ui to new core, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 37/38] console: add QemuUIInfo, Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 38/38] ui/sdl2 : initial port to SDL 2.0 (v2.0), Gerd Hoffmann, 2014/03/05
- [Qemu-devel] [PULL v4 13/38] input: keyboard: switch spice ui to new core, Gerd Hoffmann, 2014/03/05
- Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support, Peter Maydell, 2014/03/07
- Re: [Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support,
Andreas Färber <=