[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] block/raw-posix: bdrv_parse_filename() f
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/5] block/raw-posix: bdrv_parse_filename() for cdrom |
Date: |
Sun, 9 Mar 2014 13:13:21 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Saturday 08 Mar 2014 à 00:39:43 (+0100), Max Reitz wrote :
> The "host_cdrom" protocol drivers should strip the "host_cdrom:" prefix
> from filenames if present.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/raw-posix.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 4b8c183..697cd2e 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1983,7 +1983,20 @@ static BlockDriver bdrv_host_floppy = {
> .bdrv_media_changed = floppy_media_changed,
> .bdrv_eject = floppy_eject,
> };
> +#endif
>
> +#if defined(__linux__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> +static void cdrom_parse_filename(const char *filename, QDict *options,
> + Error **errp)
> +{
> + /* The prefix is optional, just as for "file". */
> + strstart(filename, "host_cdrom:", &filename);
> +
> + qdict_put_obj(options, "filename", QOBJECT(qstring_from_str(filename)));
> +}
> +#endif
> +
> +#ifdef __linux__
> static int cdrom_open(BlockDriverState *bs, QDict *options, int flags,
> Error **errp)
> {
> @@ -2070,6 +2083,7 @@ static BlockDriver bdrv_host_cdrom = {
> .instance_size = sizeof(BDRVRawState),
> .bdrv_needs_filename = true,
> .bdrv_probe_device = cdrom_probe_device,
> + .bdrv_parse_filename = cdrom_parse_filename,
> .bdrv_file_open = cdrom_open,
> .bdrv_close = raw_close,
> .bdrv_reopen_prepare = raw_reopen_prepare,
> @@ -2200,6 +2214,7 @@ static BlockDriver bdrv_host_cdrom = {
> .instance_size = sizeof(BDRVRawState),
> .bdrv_needs_filename = true,
> .bdrv_probe_device = cdrom_probe_device,
> + .bdrv_parse_filename = cdrom_parse_filename,
> .bdrv_file_open = cdrom_open,
> .bdrv_close = raw_close,
> .bdrv_reopen_prepare = raw_reopen_prepare,
> --
> 1.9.0
>
Reviewed-by: Benoit Canet <address@hidden>
- [Qemu-devel] [PATCH v2 0/5] block: Strip protocol prefixes from filenames, Max Reitz, 2014/03/07
- [Qemu-devel] [PATCH v2 1/5] block/raw-posix: bdrv_parse_filename() for hdev, Max Reitz, 2014/03/07
- [Qemu-devel] [PATCH v2 2/5] block/raw-posix: bdrv_parse_filename() for floppy, Max Reitz, 2014/03/07
- [Qemu-devel] [PATCH v2 3/5] block/raw-posix: bdrv_parse_filename() for cdrom, Max Reitz, 2014/03/07
- Re: [Qemu-devel] [PATCH v2 3/5] block/raw-posix: bdrv_parse_filename() for cdrom,
Benoît Canet <=
- [Qemu-devel] [PATCH v2 4/5] block/raw-posix: Strip protocol prefix on creation, Max Reitz, 2014/03/07
- [Qemu-devel] [PATCH v2 5/5] block/raw-win32: bdrv_parse_filename() for hdev, Max Reitz, 2014/03/07
- Re: [Qemu-devel] [PATCH v2 0/5] block: Strip protocol prefixes from filenames, Stefan Hajnoczi, 2014/03/12