[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definit
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definitions of it_age |
Date: |
Tue, 11 Mar 2014 15:02:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/11/2014 06:53 AM, address@hidden wrote:
> From: ChenLiang <address@hidden>
>
The subject line says what, but there is no WHY. The commit message
should explain why you want a signed type.
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> arch_init.c | 4 ++--
> include/migration/page_cache.h | 4 ++--
> page_cache.c | 6 +++---
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 461a10a..1c1488a 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -109,7 +109,7 @@ const uint32_t arch_type = QEMU_ARCH;
> static bool mig_throttle_on;
> static void check_guest_throttling(void);
>
> -static uint64_t bitmap_sync_cnt;
> +static int64_t bitmap_sync_cnt;
Wait. Patch 2/10 introduced this variable. Why not introduce it with
the correct type to begin with? Please reorder your series so that you
aren't churning on new code.
> -static inline uint64_t get_bitmap_sync_cnt(void)
> +static inline int64_t get_bitmap_sync_cnt(void)
> {
> return bitmap_sync_cnt;
Not to mention that my argument in patch 2 still holds - unless you are
going to export this function, it is pointless compared to just using
the variable directly.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 03/10] XBZRLE: optimize XBZRLE to decrease the cache missing, (continued)
- [Qemu-devel] [PATCH 03/10] XBZRLE: optimize XBZRLE to decrease the cache missing, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 07/10] migraion: clear the death code, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definitions of it_age, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 10/10] XBZRLE: update the doc of XBZRLE, arei.gonglei, 2014/03/11
- [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap, arei.gonglei, 2014/03/11