[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macr
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro |
Date: |
Wed, 12 Mar 2014 22:17:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/12/14 19:28, Eduardo Habkost wrote:
> The new macro will be helpful to allow us to detect too large SMP limits
> before it is too late.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> include/hw/acpi/cpu_hotplug_defs.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/hw/acpi/cpu_hotplug_defs.h
> b/include/hw/acpi/cpu_hotplug_defs.h
> index 2725b50..9f33663 100644
> --- a/include/hw/acpi/cpu_hotplug_defs.h
> +++ b/include/hw/acpi/cpu_hotplug_defs.h
> @@ -17,7 +17,15 @@
> * between C and ASL code.
> */
> #define ACPI_CPU_HOTPLUG_STATUS 4
> +
> +/* Limit for CPU arch IDs for CPU hotplug. All hotpluggable CPUs should
> + * have CPUClass.get_arch_id() < ACPI_CPU_HOTPLUG_ID_LIMIT.
> + */
> +#define ACPI_CPU_HOTPLUG_ID_LIMIT 256
> +
> +/* 256 CPU IDs, 8 bits per entry: */
> #define ACPI_GPE_PROC_LEN 32
> +
> #define ICH9_CPU_HOTPLUG_IO_BASE 0x0CD8
> #define PIIX4_CPU_HOTPLUG_IO_BASE 0xaf00
>
>
You could actually derive ACPI_GPE_PROC_LEN from
ACPI_CPU_HOTPLUG_ID_LIMIT, by dividing with CHAR_BIT. Not too important
because the two macros are adjacent and the comment explains.
Reviewed-by: Laszlo Ersek <address@hidden>
[Qemu-devel] [PATCH v2 3/4] acpi: Assert sts array limit on AcpiCpuHotplug_add(), Eduardo Habkost, 2014/03/12
[Qemu-devel] [PATCH v2 2/4] pc: Refuse CPU hotplug if the resulting APIC ID is too large, Eduardo Habkost, 2014/03/12
[Qemu-devel] [PATCH v2 4/4] pc: Refuse max_cpus if it results in too large APIC ID, Eduardo Habkost, 2014/03/12