[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest |
Date: |
Thu, 13 Mar 2014 21:39:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 13.03.2014 15:17, schrieb Peter Maydell:
> When running under qtest we don't actually have any vcpu threads
> to be starved, so the warning about the I/O thread spinning isn't
> relevant, and the way qtest manipulates the simulated clock means
> the warning is produced a lot as a false positive. Suppress it if
> qtest_enabled(), so 'make check' output is less noisy.
>
> Signed-off-by: Peter Maydell <address@hidden>
[...]
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index df3aa7a..6f06fca 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -28,3 +28,4 @@ stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_WIN32) += fd-register.o
> stub-obj-y += cpus.o
> stub-obj-y += kvm.o
> +stub-obj-y += qtest.o
[snip]
Please note that the stubs are supposed to be sorted alphabetically.
I'm still seeing two instances of the warning for i386 and x86_64 each.
But it's a clear improvement.
Thanks, applying to qom-next (with Makefile tweaked):
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg