[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type |
Date: |
Fri, 14 Mar 2014 06:36:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/14/2014 06:06 AM, address@hidden wrote:
> From: Miroslav Rezanina <address@hidden>
>
> Output error message using qemu's error_report() function when user
> provides the invalid machine type on the command line. This also saves
> time to find what issue is when you downgrade from one version of qemu
> to another that doesn't support required machine type yet (the version
> user downgraded to have to have this patch applied too, of course).
>
> Signed-off-by: Miroslav Rezanina <address@hidden>
> ---
> v7:
> - use -machine instead of -M in error help message
> - rebase to commit 0056ae2
>
> v6:
> - print help instead of list supported machines on error
> ---
> vl.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> + error_report("Unsupported machine type");
> + printf("\nUse -machine help to list supported machines!\n");
I might have used "Use '-machine help' to" to offset what the user is
supposed to type, but I can live with what you have.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature