[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring |
Date: |
Mon, 17 Mar 2014 18:08:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/14/2014 06:35 PM, Michael Tokarev wrote:
> 14.03.2014 20:51, Fabien Chouteau wrote:
>
>> hw/net/fsl_etsec/rings.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
>> index 7760272..31e6f58 100644
>> --- a/hw/net/fsl_etsec/rings.c
>> +++ b/hw/net/fsl_etsec/rings.c
>> @@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
>>
>> /* TODO: Broadcast and Multicast */
>>
>> - if (bd.flags | BD_INTERRUPT) {
>> + if (bd.flags & BD_INTERRUPT) {
>> /* Set RXFx */
> [..etc..]
>
> Hm. Has this code _ever_ worked?? :(
>
Yes because the kernel I'm using always set the BD_INTERRUPT flag.