|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace internal thread with IOThread |
Date: | Wed, 19 Mar 2014 13:37:19 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 19/03/2014 12:02, Christian Borntraeger ha scritto:
Error *local_err = NULL; s->internal_iothread = true; object_add(TYPE_IOTHREAD, vdev->name, NULL, NULL, &local_err);
This should instead use object_new and object_property_add_child to add an "internal-iothread" child to the virtio-blk device.
The namespace of -object/object-add/object_add is private to the user, QEMU code should not touch it.
Paolo
if (error_is_set(&local_err)) { error_propagate(errp, local_err); g_free(s); return; } s->iothread = iothread_find(vdev->name); assert(s->iothread); } s->ctx = iothread_get_aio_context(s->iothread);
[Prev in Thread] | Current Thread | [Next in Thread] |