[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to obje
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link() |
Date: |
Wed, 19 Mar 2014 22:27:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 19.03.2014 08:58, schrieb Stefan Hajnoczi:
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 3c000ee..68aaed6 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -204,4 +204,15 @@ void qdev_property_add_static(DeviceState *dev, Property
> *prop, Error **errp);
> */
> void qdev_prop_set_after_realize(DeviceState *dev, const char *name,
> Error **errp);
> +
> +/**
> + * @qdev_prop_allow_set_link_before_realize:
> + *
> + * Set the Error object if an attempt is made to set the link after realize.
> + * This function should be used as the check() argument to
> + * object_property_add_link().
> + */
> +void qdev_prop_allow_set_link_before_realize(Object *obj, const char *name,
> + Object *val, Error **errp);
> +
> #endif
This is copying a bad example ... no @ before function name, as done
correctly in object.h. Fixed.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes, Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 1/5] qom: split object_property_set_link(), Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 3/5] qom: make QOM link property unref optional, Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link(), Stefan Hajnoczi, 2014/03/19
- Re: [Qemu-devel] [PATCH RESEND v4 4/5] qom: add check() argument to object_property_add_link(),
Andreas Färber <=
- [Qemu-devel] [PATCH RESEND v4 5/5] virtio-rng: avoid default_backend refcount leak, Stefan Hajnoczi, 2014/03/19
- [Qemu-devel] [PATCH RESEND v4 2/5] qom: don't make link NULL on object_property_set_link() failure, Stefan Hajnoczi, 2014/03/19
- Re: [Qemu-devel] [PATCH RESEND v4 0/5] qom: link property fixes, Paolo Bonzini, 2014/03/19