[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_d
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation |
Date: |
Wed, 19 Mar 2014 22:58:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 19.03.2014 22:03, schrieb Luiz Capitulino:
> Linux guests, when using more than 4GB of RAM, may end up using 1GB pages
> to store (kernel) data. When this happens, we're unable to debug a running
> Linux kernel with GDB:
>
> (gdb) p node_data[0]->node_id
> Cannot access memory at address 0xffff88013fffd3a0
> (gdb)
>
> GDB returns this error because x86_cpu_get_phys_page_debug() doesn't support
> translating 1GB pages in IA-32e paging mode and returns an error to GDB.
>
> This commit adds support for 1GB page translation for IA32e paging.
>
> Signed-off-by: Luiz capitulino <address@hidden>
Capitulino? :)
> ---
>
> - I'm proposing this patch for 2.0 because GDB debugging of large Linux
> guests is kind of broken
Agree that it would be nice to fix, but having mainly touched the
function interface, I am dependent on reviewers here. => rc2 or .1
Regards,
Andreas
>
> - Changelog v2:
> - Move PS bit handling to if (env->hflags & HF_LMA_MASK) block
> - Update changelog
>
> target-i386/helper.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg