[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to be a power of 2 |
Date: |
Thu, 20 Mar 2014 02:48:47 +0100 |
From: Bharata B Rao <address@hidden>
PowerPC kernel expects the number of SMT threads in a core to be a power
of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel
crash if invalid threads count is specified.
Prevent this crash and make it a graceful exit from QEMU itself by
validating the user-supplied threads count.
Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stewart Smith <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
target-ppc/translate_init.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 3269c3e..5302bdc 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -7848,6 +7848,12 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error
**errp)
max_smt, kvm_enabled() ? "KVM" : "TCG");
return;
}
+ if (!is_power_of_2(smp_threads)) {
+ error_setg(errp, "Cannot support %d threads on PPC with %s, "
+ "threads count must be a power of 2.",
+ smp_threads, kvm_enabled() ? "KVM" : "TCG");
+ return;
+ }
cpu->cpu_dt_id = (cs->cpu_index / smp_threads) * max_smt
+ (cs->cpu_index % smp_threads);
--
1.8.4.5
- [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 03/13] target-ppc: Reset SPRs on CPU reset, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 06/13] target-ppc: Introduce powerisa-207-server flag, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 07/13] spapr_hcall: Fix little-endian resource handling in H_SET_MODE, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 09/13] qdev: Introduce FWPathProvider interface, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 04/13] target-ppc: Fix overallocation of opcode tables, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 10/13] spapr_llan: Add to boot device list, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 08/13] vl.c: Extend get_boot_devices_list() to ignore suffixes, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to be a power of 2,
Andreas Färber <=
- [Qemu-devel] [PULL for-2.0 02/13] spapr_hcall: Fix h_enter to loop correctly, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 11/13] spapr_vio: Fix firmware names, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 12/13] spapr: QOM'ify pseries machine, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 13/13] spapr: Implement interface to fix device pathname, Andreas Färber, 2014/03/19
- Re: [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2, Peter Maydell, 2014/03/20