[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as
From: |
Chen Fan |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu() |
Date: |
Thu, 20 Mar 2014 14:25:13 +0800 |
On Wed, 2014-03-19 at 16:27 -0300, Eduardo Habkost wrote:
> On Wed, Mar 19, 2014 at 04:53:41PM +0800, Chen Fan wrote:
> > introduce x86_cpu_topo_ids_from_index() to calculate the cpu topology
> > information, and the compat old mode mechanism moved into there.
> > remove unused funciton x86_apicid_from_cpu_idx().
> >
> > Signed-off-by: Chen Fan <address@hidden>
> [...]
> > -static inline apic_id_t x86_apicid_from_cpu_idx(unsigned nr_cores,
> > - unsigned nr_threads,
> > - unsigned cpu_index)
> > +static inline void x86_topo_ids_from_apic_id(unsigned nr_cores,
> > + unsigned nr_threads,
> > + apic_id_t apic_id,
> > + X86CPUTopoInfo *topo)
>
> You need to squash this patch and patch 3/4 together, otherwise we get
> unit test failures in the intermediate tree.
Ok, this patches will come soon.
Thanks
>
> Otherwise, patch looks good.
>
- Re: [Qemu-devel] [RFC v3 1/3] cpu: introduce CpuTopoInfo structure for argument simplification, (continued)
- Re: [Qemu-devel] [RFC v3 1/3] cpu: introduce CpuTopoInfo structure for argument simplification, Eduardo Habkost, 2014/03/11
- [Qemu-devel] [RFC v3 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), chen.fan.fnst, 2014/03/11
- Re: [Qemu-devel] [RFC v3 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Eduardo Habkost, 2014/03/11
- Re: [Qemu-devel] [RFC v3 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Chen Fan, 2014/03/12
- [Qemu-devel] [RFC v4 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu, Chen Fan, 2014/03/12
- [Qemu-devel] [RFC v4 1/3] cpu: introduce CpuTopoInfo structure for argument simplification, Chen Fan, 2014/03/12
- Re: [Qemu-devel] [RFC v4 1/3] cpu: introduce CpuTopoInfo structure for argument simplification, Eduardo Habkost, 2014/03/12
- [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu, Chen Fan, 2014/03/19
- [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Chen Fan, 2014/03/19
- Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Eduardo Habkost, 2014/03/19
- Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(),
Chen Fan <=
- [Qemu-devel] [PATCH v1 3/4] topo unit-test: update Unit tests to test-x86-cpuid.c, Chen Fan, 2014/03/19
- [Qemu-devel] [PATCH v1 1/4] cpu: introduce CpuTopoInfo structure for argument simplification, Chen Fan, 2014/03/19
- [Qemu-devel] [PATCH v1 4/4] i386: introduce cpu QOM hierarchy tree, Chen Fan, 2014/03/19
- Re: [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu, Eric Blake, 2014/03/19
- Re: [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu, Chen Fan, 2014/03/19
- [Qemu-devel] [RFC v4 3/3] i386: introduce cpu QOM hierarchy tree, Chen Fan, 2014/03/12
- [Qemu-devel] [RFC v4 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Chen Fan, 2014/03/12
- Re: [Qemu-devel] [RFC v4 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu(), Eduardo Habkost, 2014/03/12
- [Qemu-devel] [RFC v3 3/3] i386: introduce cpu QOM hierarchy tree, chen.fan.fnst, 2014/03/11
[Qemu-devel] [RFC v2 2/2] i386: introduce cpu QOM hierarchy tree, Chen Fan, 2014/03/04