[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocat
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option |
Date: |
Thu, 20 Mar 2014 14:38:32 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 17.03.2014 um 07:53 hat Hu Tao geschrieben:
> This adds a preallocation=full mode to qcow2 image creation, which
> creates a non-sparse image file.
>
> Signed-off-by: Hu Tao <address@hidden>
I see that you changed the implementation from bdrv_preallocate() to
bdrv_create() options in v4 after Stefan had asked whether
bdrv_preallocate() was really necessary or just complicating things.
In hindsight, do you really think the new code is simpler? I certainly
think this one is rather adventurous and the formulas to precalculate
the image file size are easy to get wrong.
Kevin
- [Qemu-devel] [PATCH v7 for 2.0 0/4] qemu-img: add preallocation=full, Hu Tao, 2014/03/17
- [Qemu-devel] [PATCH v7 for 2.0 1/4] qapi: introduce PreallocMode and a new PreallocMode full., Hu Tao, 2014/03/17
- [Qemu-devel] [PATCH v7 for 2.0 3/4] raw-posix: Add full image preallocation option, Hu Tao, 2014/03/17
- [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option, Hu Tao, 2014/03/17
- Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option,
Kevin Wolf <=
- [Qemu-devel] [PATCH v7 for 2.0 2/4] raw, qcow2: don't convert file size to sector size, Hu Tao, 2014/03/17