[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big
From: |
Marcel Apfelbaum |
Subject: |
[Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines |
Date: |
Thu, 20 Mar 2014 23:14:59 +0200 |
There is an issue with iasl on big endian machines: It
cannot disassemble acpi tables taken from little endian
machines, so we cannot check the expected tables.
Do not run iasl on those machines until this
problem is solved by the acpica community.
Signed-off-by: Marcel Apfelbaum <address@hidden>
---
V2 -> V3:
Addressed Michael S. Tsirkin's review:
- tests don't need to re-run detection, use configure
to figure out if it is an LE machine.
V1 -> V2:
Addressed an offline tip for a much cleaner
macro line, thanks!
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index aae617e..2c0a3b2 100755
--- a/configure
+++ b/configure
@@ -4656,7 +4656,10 @@ else
fi
echo "PYTHON=$python" >> $config_host_mak
echo "CC=$cc" >> $config_host_mak
-if $iasl -h > /dev/null 2>&1; then
+# All known versions of iasl on BE machines are broken.
+# TODO: add detection code once a non-broken version makes an appearance.
+if ($iasl -h > /dev/null 2>&1) &&
+ (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
echo "IASL=$iasl" >> $config_host_mak
fi
echo "CC_I386=$cc_i386" >> $config_host_mak
--
1.8.3.1
- [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines,
Marcel Apfelbaum <=
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Paolo Bonzini, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Marcel Apfelbaum, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Peter Maydell, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Marcel Apfelbaum, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Peter Maydell, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Michael S. Tsirkin, 2014/03/23
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Peter Maydell, 2014/03/23
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Michael S. Tsirkin, 2014/03/23
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Marcel Apfelbaum, 2014/03/20