[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 3/5] vmstate: add VMS_MUST_EXIST
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC v2 3/5] vmstate: add VMS_MUST_EXIST |
Date: |
Tue, 25 Mar 2014 09:23:13 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Michael S. Tsirkin (address@hidden) wrote:
> On Mon, Mar 24, 2014 at 05:11:16PM +0000, Dr. David Alan Gilbert wrote:
<snip>
> > I think your intent here is just to misuse the field_exist function pointer
> > as a call for a different reason as a hook for a validator; is it really
> > worth
> > misusing it like that or is something more explicit worth it?
> > Perhaps something passed an Error** so it could pass back what was wrong?
>
>
> Well adding a required field seems valuable by itself, does it not?
Maybe; however most fields are always-present, unless they have a test
function or minimum version, so it's a little weird to add a 'required'
when that's the default.
> And there's no way to pass in Error** since none of the callers
> has Error**: all of migration still uses stderr to pass
> errors.
>
> So we could add an API but it doesn't seem too valuable.
>
> Since all callers will use this through a wrapper like VMSTATE_TEST,
> it will be easy to change our mind later.
Yep, that's fine - was just an idea.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Qemu-devel] [RFC v2 4/5] vmstate: add VMSTATE_TEST, Michael S. Tsirkin, 2014/03/24
[Qemu-devel] [RFC v2 5/5] hpet: fix buffer overrun on invalid state load, Michael S. Tsirkin, 2014/03/24
Re: [Qemu-devel] [RFC v2 0/5] state loading security issues, Michael S. Tsirkin, 2014/03/24