Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

[Marcel Apfelbaum]

On Thu, 2014-03-27 at 09:16 +0800, Chen Gang wrote:
> At present, each 'opt_name' of 'accel_list' is uniq with each other, so
> 'buf' can only match one 'opt_name'.
> 
> When drop into the matching code block, can 'break' outside related
> 'for' looping after finish processing it (just like the other 'break'
> within the matching block).
> 
> After print "... not support for this target", it can avoid to print
> "... accelerator does not exist".
Hi,
Thanks for the patch!

I would re-write
1. The commit subject to:
   Fix wrong warning on configure_accelerator
2. The commit message to:
   No need to continue to iterate over the accelerators list
   after a match is found, even if it is not supported.

> 
> 
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  vl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 842e897..b4f98fa 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine)
>                  if (!accel_list[i].available()) {
>                      printf("%s not supported for this target\n",
>                             accel_list[i].name);
> -                    continue;
> +                    break;
Seems like the right thing to do.

Thanks,
Marcel

>                  }
>                  *(accel_list[i].allowed) = true;
>                  ret = accel_list[i].init(machine);