[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/14] linux-user: Assert stack used for auxvec, envp
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PULL 02/14] linux-user: Assert stack used for auxvec, envp, argv |
Date: |
Fri, 2 May 2014 22:15:37 +0300 |
From: James Hogan <address@hidden>
Assert that the amount of stack space used for auxvec, envp & argv
exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
updated when another NEW_AUX_ENT is added.
Signed-off-by: James Hogan <address@hidden>
Cc: Riku Voipio <address@hidden>
Cc: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/elfload.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index d2380b6..ecf6f35 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1455,6 +1455,8 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc,
int envc,
info->auxv_len = sp_auxv - sp;
sp = loader_build_argptr(envc, argc, sp, p, 0);
+ /* Check the right amount of stack was allocated for auxvec, envp & argv.
*/
+ assert(sp_auxv - sp == size);
return sp;
}
--
2.0.0.rc0
- [Qemu-devel] [PULL 00/14] linux-user update, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 01/14] linux-user: Add /proc/self/exe open forwarding, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 03/14] linux-user: Move if-elses to a switch statement., riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 06/14] linux-user: avoid using glibc internals in _syscall5 and in definition of target_sigevent struct, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 02/14] linux-user: Assert stack used for auxvec, envp, argv,
riku . voipio <=
- [Qemu-devel] [PULL 11/14] linux-user/elfload.c: Fix incorrect ARM HWCAP bits, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 08/14] linux-user: rename cpu- uname -> uname, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 05/14] linux-user: Handle arches with llseek instead of _llseek, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 04/14] linux-user: Add support for SCM_CREDENTIALS., riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 14/14] linux-user/elfload.c: Support ARM HWCAP2 flags, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 07/14] linux-user/signal.c: Set fault address in AArch64 signal info, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 13/14] linux-user/elfload.c: Fix A64 code which was incorrectly acting like A32, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 12/14] linux-user/elfload.c: Update ARM HWCAP bits, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 10/14] linux-user: remove configure option for setting uname release, riku . voipio, 2014/05/02
- [Qemu-devel] [PULL 09/14] linux-user: move uname functions to uname.c, riku . voipio, 2014/05/02