[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after v
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after visit_start_struct() fails |
Date: |
Tue, 06 May 2014 14:22:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/02/2014 06:44 AM, Markus Armbruster wrote:
>> When visit_start_struct() succeeds, visit_end_struct() must not be
>
> s/succeeds/fails/ (this really confused me on my first read, until I saw
> the code and the subject line and determined the typo)
D'oh! Will fix both here an in 10/13/
>> called. rtc_get_date() and balloon_stats_all() call it anyway. As
>> far as I can tell, they're only used with the string output visitor,
>> which doesn't care. Fix them anyway.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> hw/timer/mc146818rtc.c | 23 +++++++++++++++--------
>> hw/virtio/virtio-balloon.c | 25 +++++++++++++++++++------
>> 2 files changed, 34 insertions(+), 14 deletions(-)
>
> With commit message fixed,
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes, (continued)
- [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of field prefix, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 13/13] error: error_is_set() is finally unused; remove, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 11/13] tests: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 10/13] hw: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/02