[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppr
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors |
Date: |
Wed, 07 May 2014 08:08:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/02/2014 05:26 AM, Markus Armbruster wrote:
>> Using error_is_set(errp) that way can sweep programming errors under
>> the carpet when we get called incorrectly with an error set.
>>
>> encrypted_bdrv_it() does it, because there's no way to make
>> bdrv_iterate() break its loop. Actually safe, because qmp_cont()
>> clears the error before the loop. Clean it up anyway: replace
>> bdrv_iterate() by bdrv_next(), break the loop on error.
>>
>> Replace both occurences, for consistency.
>
> s/occurences/occurrences/
>
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Fixing up the commit message typo is trivial and doesn't alter the
> positive review.
Luiz, could you fix it up on commit, when you add Eric's R-by?
- [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 03/14] qmp: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 04/14] error: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 12/14] qemu-option: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 10/14] qga: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 02/14] qga: Consistently name Error ** objects errp, and not err, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 08/14] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 13/14] dump: Drop pointless error_is_set(), DumpState member errp, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 09/14] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 06/14] hmp: Guard against misuse of hmp_handle_error(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 11/14] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH v3 01/14] qmp hmp: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/05/02