[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to match current code |
Date: |
Wed, 07 May 2014 09:51:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/05/2014 12:49 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>
>>>> Example:
>>>>
>>>> address@hidden:~/w/qemu2.git$ cat qapi-generated/example-qmp-marshal.c
>>>
>>> The file was missing the example command line that generated this file;
>>> I figured it out:
>>>
>>> address@hidden:~/w/qemu2.git$ python scripts/qapi-commands.py \
>>> --output-dir="qapi-generated" --prefix="example-" <
>>> example-schema.json
>>>
>>> if you want to add that to this patch.
>>
>> Sure, why not, but if there's nothing else to correct in this series,
>> I'd prefer a separate commit to a respin.
>
> Followup commit is just fine, if I don't turn up anything else while
> reviewing the rest of the series.
Followup commit. because my fix conflicts with a patch in Luiz's queue.
I'll wait for that to land, then post my fix on top.
[Qemu-devel] [PATCH 04/13] qapi: Replace start_optional()/end_optional() by optional(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 08/13] qapi: Un-inline visit of implicit struct, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 03/13] qapi: Remove unused Visitor callbacks start_handle(), end_handle(), Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 09/13] hmp: Call visit_end_struct() after visit_start_struct() succeeds, Markus Armbruster, 2014/05/02
[Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup, Markus Armbruster, 2014/05/02