[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 2/7] hw/net/stellaris_enet: Correct handling of p
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v4 2/7] hw/net/stellaris_enet: Correct handling of packet padding |
Date: |
Thu, 8 May 2014 12:53:02 +0100 |
The PADEN bit in the transmit control register enables padding of short
data packets out to the required minimum length. However a typo here
meant we were adjusting tx_fifo_len rather than tx_frame_len, so the
padding didn't actually happen. Fix this bug.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Cc: address@hidden
---
hw/net/stellaris_enet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
index bd844cd..d0da819 100644
--- a/hw/net/stellaris_enet.c
+++ b/hw/net/stellaris_enet.c
@@ -265,7 +265,7 @@ static void stellaris_enet_write(void *opaque, hwaddr
offset,
s->tx_frame_len -= 4;
if ((s->tctl & SE_TCTL_PADEN) && s->tx_frame_len < 60) {
memset(&s->tx_fifo[s->tx_frame_len], 0, 60 -
s->tx_frame_len);
- s->tx_fifo_len = 60;
+ s->tx_frame_len = 60;
}
qemu_send_packet(qemu_get_queue(s->nic), s->tx_fifo,
s->tx_frame_len);
--
1.9.2
- [Qemu-devel] [PATCH v4 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 4/7] hw/net/stellaris_enet: Correctly implement the TR and THR registers, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 1/7] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 7/7] hw/net/stellaris_enet: Convert to vmstate, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 5/7] hw/net/stellaris_enet: Fix debug format strings, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 2/7] hw/net/stellaris_enet: Correct handling of packet padding,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer, Peter Maydell, 2014/05/08
- [Qemu-devel] [PATCH v4 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code, Peter Maydell, 2014/05/08