[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux vers
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version |
Date: |
Thu, 08 May 2014 15:59:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Don Slutz <address@hidden> writes:
> On 05/06/14 14:16, Mike Day wrote:
>> This updates scripts/checkpatch.pl to version 0.32. Also,
>> forward-ported the QEMU checks for no tabs and correct capitalization
>> of "QEMU." Finally, make --no-tree the default option since this will
>> be used with Qemu.
>>
>> Signed-off-by: Mike Day <address@hidden>
>> ---
>>
>> Notes: This is a huge patch and I needed to include white space
>> changes to get it applying cleanly.
>>
>> I've tested this so far with some random patches off the mailing list
>> and some others that I've got around. I also tested for some intentional
>> errors.
>>
>> scripts/checkpatch.pl | 2544
>> ++++++++++++++++++++++++++++++++++++++++---------
>> 1 file changed, 2120 insertions(+), 424 deletions(-)
>>
>>
>
> I have used to following to see how a new version compares:
>
>
> k=500;i=0;j=0;for sha in $(git log --no-merges --format=format:"%h"
> -$k);do let i=$i+1; git show $sha >/tmp/a; clear;echo $i;head -20
> /tmp/a; ./scripts/checkpatch.pl --root=. /tmp/a; err=$?; if [ $err !=
> 0 ]; then let j=$j+1;read foo;fi; done;echo Check $i, Bad $j
>
> ...
> total: 0 errors, 0 warnings, 79 lines checked
>
> /tmp/a has no obvious style problems and is ready for submission.
> Check 500, Bad 52
How does your new checkpatch compare to our current one?