[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram siz
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size |
Date: |
Mon, 12 May 2014 06:39:38 +0000 |
Hi,
> > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> > index d1afc76..399a2ef 100644
> > --- a/hw/display/cirrus_vga.c
> > +++ b/hw/display/cirrus_vga.c
> > @@ -2959,6 +2959,14 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev)
> > PCIDeviceClass *pc = PCI_DEVICE_GET_CLASS(dev);
> > int16_t device_id = pc->device_id;
> >
> > + /* follow real hardware, cirrus card emulated has 4 MB video
> memory.
> > + Also accept 8 MB/16 MB for backward compatibility. */
> > + if (s->vga.vram_size_mb != 4 || s->vga.vram_size_mb != 8 ||
> > + s->vga.vram_size_mb != 16) {
>
> This condition will always be true, because a number can't be equal
> to 3 _different_ numbers at the same time.
>
Yep, good catch. Thanks.
Best regards,
-Gonglei