[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset me
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method |
Date: |
Mon, 12 May 2014 09:15:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Am 02.05.2014 16:33, schrieb Paolo Bonzini:
> Now that we have a CPU object with a reset method, it is better to
> keep the KVM reset close to the CPU reset. Using qemu_register_reset
> as we do now keeps them far apart.
>
> With this patch, PPC no longer calls the kvm_arch_ function, so
> it can get removed there. Other arches call it from their CPU
> reset handler, and the function gets an ARMCPU/X86CPU/S390CPU.
>
> Note that ARM- and s390-specific functions are called kvm_arm_*
> and kvm_s390_*, while x86-specific functions are called kvm_arch_*.
> That follows the convention used by the different architectures.
> Changing that is the topic of a separate patch.
>
> Reviewed-by: Gleb Natapov <address@hidden>
> Reviewed-by: Andreas Färber <address@hidden>
Re-reviewed, looks good now, please take it through the KVM tree.
Thanks,
Andreas
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/sysemu/kvm.h | 2 --
> kvm-all.c | 11 -----------
> target-arm/cpu.c | 7 +++++++
> target-arm/kvm32.c | 4 +---
> target-arm/kvm64.c | 2 +-
> target-arm/kvm_arm.h | 8 ++++++++
> target-i386/cpu.c | 5 +++++
> target-i386/kvm.c | 3 +--
> target-i386/kvm_i386.h | 1 +
> target-ppc/kvm.c | 4 ----
> target-s390x/cpu.c | 4 ++++
> target-s390x/cpu.h | 5 +++++
> target-s390x/kvm.c | 6 ++++--
> 13 files changed, 37 insertions(+), 25 deletions(-)
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 0/8] x86: correctly implement soft reset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method, Paolo Bonzini, 2014/05/02
- Re: [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 3/8] target-i386: fix set of registers zeroed on reset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 4/8] target-i386: preserve FPU and MSR state on INIT, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstrap processor, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 2/8] kvm: forward INIT signals coming from the chipset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 7/8] pc: port 92 reset requires a low->high transition, Paolo Bonzini, 2014/05/02