[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstra
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstrap processor |
Date: |
Mon, 12 May 2014 09:36:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Am 02.05.2014 16:33, schrieb Paolo Bonzini:
> SIPI interrupts are ignored on the bootstrap. Never accept one.
>
> Cc: Andreas Färber <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/intc/apic_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index 7ecce2d..05c0e08 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -200,7 +200,7 @@ void apic_init_reset(DeviceState *dev)
> s->initial_count = 0;
> s->initial_count_load_time = 0;
> s->next_time = 0;
> - s->wait_for_sipi = 1;
> + s->wait_for_sipi = !cpu_is_bsp(s->cpu);
I wondered whether this will work on hot-add. I believe so, since the
device is reset on realized=true after executing the realize hook, and
the APIC gets realized as part of the CPU (but before it's reset).
Reviewed-by: Andreas Färber <address@hidden>
Andreas
>
> if (s->timer) {
> timer_del(s->timer);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 0/8] x86: correctly implement soft reset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 3/8] target-i386: fix set of registers zeroed on reset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 4/8] target-i386: preserve FPU and MSR state on INIT, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstrap processor, Paolo Bonzini, 2014/05/02
- Re: [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstrap processor,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 2/8] kvm: forward INIT signals coming from the chipset, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 7/8] pc: port 92 reset requires a low->high transition, Paolo Bonzini, 2014/05/02
- [Qemu-devel] [PATCH v2 6/8] cpu: make CPU_INTERRUPT_RESET available on all targets, Paolo Bonzini, 2014/05/02
- Re: [Qemu-devel] [PATCH v2 6/8] cpu: make CPU_INTERRUPT_RESET available on all targets, Peter Maydell, 2014/05/23