Re: [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> Rather than include helper.h with N values of GEN_HELPER, include a
> secondary file that sets up the macros to include helper.h.  This
> minimizes the files that must be rebuilt when changing the macros
> for file N.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  include/exec/helper-gen.h                    |  92 +++++++++++++++++
>  include/exec/{def-helper.h => helper-head.h} | 144 
> +--------------------------
>  include/exec/helper-proto.h                  |  38 +++++++
>  include/exec/helper-tcg.h                    |  35 +++++++

I still find the macro gymnastics of the helper generators a pain
because hitting "find" on gen_helper_foo doesn't lead you anywhere
useful but I guess that's the price you pay for using macros.

Reviewed-by: Alex Bennée <address@hidden>

-- 
Alex Bennée