[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_ai
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_aio_context() |
Date: |
Thu, 15 May 2014 09:34:20 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 05/08 16:34, Stefan Hajnoczi wrote:
> Implement .bdrv_detach/attach_aio_context() interfaces to propagate
> detach/attach to BDRVVmdkState->extents[].file. The block layer takes
> care of ->file and ->backing_hd but doesn't know about our extents
> BlockDriverStates, which is also part of the graph.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
Noticed this doesn't apply any more due to recent VMDK fixes, because the
context is different. Trivial to fix, though.
> block/vmdk.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 06a1f9f..1ca944a 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -2063,6 +2063,27 @@ static ImageInfoSpecific
> *vmdk_get_specific_info(BlockDriverState *bs)
> return spec_info;
> }
>
> +static void vmdk_detach_aio_context(BlockDriverState *bs)
> +{
> + BDRVVmdkState *s = bs->opaque;
> + int i;
> +
> + for (i = 0; i < s->num_extents; i++) {
> + bdrv_detach_aio_context(s->extents[i].file);
> + }
> +}
> +
> +static void vmdk_attach_aio_context(BlockDriverState *bs,
> + AioContext *new_context)
> +{
> + BDRVVmdkState *s = bs->opaque;
> + int i;
> +
> + for (i = 0; i < s->num_extents; i++) {
> + bdrv_attach_aio_context(s->extents[i].file, new_context);
> + }
> +}
> +
> static QEMUOptionParameter vmdk_create_options[] = {
> {
> .name = BLOCK_OPT_SIZE,
> @@ -2118,6 +2139,8 @@ static BlockDriver bdrv_vmdk = {
> .bdrv_has_zero_init = vmdk_has_zero_init,
> .bdrv_get_specific_info = vmdk_get_specific_info,
> .bdrv_refresh_limits = vmdk_refresh_limits,
> + .bdrv_detach_aio_context = vmdk_detach_aio_context,
> + .bdrv_attach_aio_context = vmdk_attach_aio_context,
>
> .create_options = vmdk_create_options,
> };
> --
> 1.9.0
>
>
- [Qemu-devel] [PATCH v3 14/25] block/raw-posix: implement .bdrv_detach/attach_aio_context(), (continued)
- [Qemu-devel] [PATCH v3 14/25] block/raw-posix: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 15/25] block/linux-aio: fix memory and fd leak, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 16/25] block/raw-win32: create one QEMUWin32AIOState per BDRVRawState, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 17/25] block/raw-win32: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 20/25] ssh: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- Re: [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_aio_context(),
Fam Zheng <=
- [Qemu-devel] [PATCH v3 22/25] dataplane: use the QEMU block layer for I/O, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 23/25] dataplane: delete IOQueue since it is no longer used, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 19/25] sheepdog: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 24/25] dataplane: implement async flush, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 25/25] raw-posix: drop raw_get_aio_fd() since it is no longer used, Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 06/25] blkverify: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 13/25] quorum: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 10/25] nbd: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/08
- [Qemu-devel] [PATCH v3 12/25] qed: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/08