[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot |
Date: |
Thu, 15 May 2014 15:26:12 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.05.2014 um 15:07 hat Mike Day geschrieben:
> On Wed, May 14, 2014 at 11:15 AM, Kevin Wolf <address@hidden> wrote:
> >> freeing the extra clusters.
> >
> > Do you have an easy reproducer? Because I can't see the bug.
>
> Thanks for the review! I was having a hard time reproducing this until
> I did a bisect. This bug was fixed by 65f33bc which was merged at or
> after the time I submitted the patch:
>
> qcow2: Fix alloc_clusters_noref() overflow detection
>
> I can reproduce the bug by checking out the immediate ancestor
> 43cbeffb1, creating a single snapshot in a qcow2 image, and then
> attempting to delete that snapshot.
>
> The error I get is:
> qemu-img: Could not delete snapshot 'snapone': (Failed to remove
> snapshot from snapshot list: File too large)
>
> This is the error that is fixed by 65f33bc
Yes, that makes sense. Thanks Mike. I think we can disregard your patch
then and consider the problem fixed.
Kevin