[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties |
Date: |
Mon, 19 May 2014 18:50:53 +0300 |
On Mon, May 19, 2014 at 05:36:38PM +0200, Alexander Graf wrote:
>
> On 19.05.14 17:10, Michael S. Tsirkin wrote:
> >On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
> >>On 19.05.14 10:38, Greg Kurz wrote:
> >>>Hi,
> >>>
> >>>This patch set tries to address comments from the initial
> >>>review. For this round, I have focused on two changes:
> >>>- as suggested by Andreas, we now call the device specific
> >>> code from the generic code to ease the implementation of
> >>> future devices. This is achieved with the addition of
> >>> load/save methods to VirtioDeviceClass.
> >>>- virtio subsections now implement a "needed" concept with
> >>> the same semantics as in the VMState code.
> >>>
> >>>I haven't looked at compat mode issues yet, but it is
> >>>on my TODO list.
> >>If you fix up the comments to be either
> >>
> >> /*
> >> * foo
> >> */
> >>
> >>or
> >>
> >> /* foo */
> >>
> >>style, not
> >>
> >> /* foo
> >> */
> >>
> >>then you get my
> >>
> >>
> >>Acked-by: Alexander Graf <address@hidden>
> >>
> >>
> >>Alex
> >Documented anywhere?
>
> Impressive. I thought it was, but apparently I'm wrong :). Nevermind then.
>
> >Linux style is
> >
> > /* Always
> > * like this.
> > */
> >
> >so it's definitely not universal.
>
> Eh - documented anywhere? Linux usually goes with C style comments.
>
>
> Alex
Actually, what I said is only true for networking, I'm
just hacking in that field recently.
It's all in Documentation/CodingStyle:
The preferred style for long (multi-line) comments is:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
For files in net/ and drivers/net/ the preferred style for long (multi-line)
comments is a little different.
/* The preferred comment style for files in net/ and drivers/net
* looks like this.
*
* It is nearly the same as the generally preferred comment style,
* but there is no initial almost-blank line.
*/